Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flamegraph is squeezed in adhoc comparison UI #1333

Closed
eh-am opened this issue Aug 1, 2022 · 2 comments · Fixed by #1327
Closed

Flamegraph is squeezed in adhoc comparison UI #1333

eh-am opened this issue Aug 1, 2022 · 2 comments · Fixed by #1327
Assignees
@eh-am
Labels
frontend Mostly JS code

Comments

@eh-am
Copy link
Collaborator

eh-am commented Aug 1, 2022

image
@eh-am eh-am added the frontend Mostly JS code label Aug 1, 2022
@eh-am eh-am self-assigned this Aug 1, 2022
@eh-am
Copy link
Collaborator Author

eh-am commented Aug 1, 2022

There's a panesOrientation="vertical" property we can use.

@Rperry2174
Copy link
Contributor

Rperry2174 commented Aug 1, 2022 •
edited
Loading

yeah I don't think "both" (horizontally) should be an option here on comparison page because there's no way to get four things all in one row.. If we make it vertical that should work much better

@eh-am eh-am mentioned this issue Aug 2, 2022
Merged
eh-am added a commit that referenced this issue Aug 3, 2022
@eh-am
feat: upload any arbitrary data (collapsed/pprof/json) via adhoc ui (#…
6620888 
…1327)

Allow "uploading"[0] pprof/collapsed (aka folded) via adhoc UI.

* migrate to redux toolkit
* migrate to typescript
* fixes #1333 (Flamegraph is squeezed in adhoc comparison UI #1333)
* have that same logic continuous have of being able to easily change from single/comparison/diff and keeping the same profile in memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eh-am eh-am

Labels
frontend Mostly JS code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: upload any arbitrary data (collapsed/pprof/json) via adhoc ui grafana/pyroscope
2 participants
@eh-am @Rperry2174