Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flamegraph): User should be able to adjust title visibility over the Flamegraph #1073

Merged
merged 3 commits into from
May 2, 2022

Conversation

pavelpashkovsky
Copy link
Contributor

@pavelpashkovsky pavelpashkovsky commented Apr 29, 2022

FIX: #1072

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 500.4 KB (0%) 10.1 s (0%) 2.4 s (-0.92% 🔽) 12.4 s

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1073 (09deafa) into main (d2af864) will increase coverage by 0.01%.
The diff coverage is 88.89%.

@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   70.97%   70.98%   +0.01%     
==========================================
  Files          85       85              
  Lines        2921     2922       +1     
  Branches      624      731     +107     
==========================================
+ Hits         2073     2074       +1     
  Misses        845      845              
  Partials        3        3              
Impacted Files Coverage Δ
...e-flamegraph/src/FlameGraph/FlameGraphRenderer.tsx 52.46% <ø> (+0.40%) ⬆️
...graph/src/FlameGraph/FlameGraphComponent/index.tsx 84.69% <75.00%> (ø)
...raph/src/FlameGraph/FlameGraphComponent/Header.tsx 90.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2af864...09deafa. Read the comment docs.

Copy link
Collaborator

@eh-am eh-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to make this all so fine grained, if we start adding one flag for everything, the api is gonna become bloated quite soon.

Can't we reuse one of the existing variables? Maybe showToolbar?

@pavelpashkovsky
Copy link
Contributor Author

@eh-am, make sense, replaced with showToolbar

@pavelpashkovsky pavelpashkovsky force-pushed the flamegraph-title-visibility branch from 5d52f29 to 09deafa Compare April 29, 2022 13:38
@Rperry2174 Rperry2174 merged commit bd74aae into main May 2, 2022
@Rperry2174 Rperry2174 deleted the flamegraph-title-visibility branch May 2, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to hide header text in flamegraph component
3 participants