Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multidimensional datasets with xarray #46

Open
eb8680 opened this issue Oct 14, 2019 · 2 comments
Open

Multidimensional datasets with xarray #46

eb8680 opened this issue Oct 14, 2019 · 2 comments

Comments

@eb8680
Copy link
Member

eb8680 commented Oct 14, 2019

Currently brmp expects data in the form of Pandas dataframes, but when working with larger, higher-dimensional datasets it might be more convenient to specify formulas in terms of multidimensional xarray Dataset objects.

This would probably require substantial changes to brmp's code generation infrastructure, however, and is not high priority.

@neerajprad
Copy link
Member

Looking at http://xarray.pydata.org/en/stable/pandas.html, I think we should be able to swap pandas for xarray internally in the future.

@null-a
Copy link
Collaborator

null-a commented Oct 16, 2019

This would probably require substantial changes to brmp's code generation infrastructure,

The design matrix coding module is the only place we work with data frames, and I don't think we do much more than fetch columns by name, check column types (categorical, numeric, etc.), and fetch a list of levels present in a categorical column. So switching to working with xarray or some generic interface will hopefully be relatively painless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants