Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing send_packet for async client ? #135

Closed
MikhailMS opened this issue May 7, 2020 · 3 comments
Closed

Missing send_packet for async client ? #135

MikhailMS opened this issue May 7, 2020 · 3 comments

Comments

@MikhailMS
Copy link

Is it just me, or there are 2 lines of code missing here and here to allow async client to send acct and coa packets ?

I've seen a PR about it, but it's not been merged into master
@Istvan91
Copy link
Collaborator

Istvan91 commented May 7, 2020

That is correct, it is missing and not yet included... I'll take care of it

@Istvan91
Copy link
Collaborator

Istvan91 commented May 7, 2020

Done, if there is no follow up, I'll close this ticket soon

@MikhailMS
Copy link
Author

That was fast :)

Thank you very much and thanks for making this package - really useful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Istvan91 @MikhailMS