Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyable 'pip install <foo>' line should likely quote <foo> in some cases #8426

Closed
Julian opened this issue Aug 13, 2020 · 2 comments · Fixed by #8444
Closed

Copyable 'pip install <foo>' line should likely quote <foo> in some cases #8426

Julian opened this issue Aug 13, 2020 · 2 comments · Fixed by #8444
Labels
bug 🐛 good first issue This issue is ideal for first-time contributors! UX/UI design, user experience, user interface

Comments

@Julian
Copy link
Contributor

Julian commented Aug 13, 2020

Describe the bug
PyPI shows a copyable pip install <foo> command line, and includes the version when visiting a particular release. (Though there's some discussion in #1563 and #3006 about improving or dropping it).

For a release containing a PEP 440 Epoch, Warehouse shows:

Screen Shot 2020-08-13 at 19 11 54

The line there is likely not something someone wants to copy paste.

In various shells (zsh, bash) the ! there will trigger history completion or the like (so 3!2 will complete in the history line number 2 in the shell history file).

Expected behavior
<foo> should be quoted, at least in the above case, perhaps others, though I can't think of any.

To Reproduce
https://pypi.org/project/composition/8!6.75309/

My Platform
Firefox 80.0b2 (64-bit), macOS


Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide.

@di di added bug 🐛 UX/UI design, user experience, user interface good first issue This issue is ideal for first-time contributors! labels Aug 14, 2020
@di
Copy link
Member

di commented Aug 14, 2020

Thanks for the report! We probably want to do this conditionally based on whether the version contains an epoch.

(I've added the "good first issue" label to this issue)

@dstufft
Copy link
Member

dstufft commented Aug 15, 2020

Another option is to quote it all the time, but have the copy/paste button inject the quotes, and leave the visible display alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 good first issue This issue is ideal for first-time contributors! UX/UI design, user experience, user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants