-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyQt5 and PySide2 wheels sometimes fail hash checks after incomplete download #8330
Comments
Looks like pypa/pip#8510 might be an existing issue in the pip issue tracker. Generally this is due to network connectivity issues, however I'm not sure that pip should be attempting to hash-check the download if it clearly hasn't completed downloading, that's somewhat confusing. FWIW I ran your script and could not reproduce this. |
I'm trying with both pip and wget right now and they are all succeeding. Same as 'the other night' when I tried this. Though I did have both a GHA and an RTD failure recently. Anyways, if anyone has more info I could try to provide I'll see what I can do. I'll follow up if I can get any more failures locally. @di, thanks for looking and trying to recreate it. |
I don't know that these are of any help but here are a few failures I've capture locally. I don't have a failure rate for these local runs but it's not particularly often. On the other hand, for a bit in GitHub Actions it was every other build or so (each with 24+jobs downloading either PyQt5 or PySide2). The first one seems like something else I figure. + wget https://files.pythonhosted.org:443/packages/24/39/348e72c1607ac12915e1809e9092e09aa239bc48ace41d51253179e635bb/PySide2-5.15.0-5.15.0-cp35.cp36.cp37.cp38-abi3-manylinux1_x86_64.whl
--2020-07-29 18:39:03-- https://files.pythonhosted.org/packages/24/39/348e72c1607ac12915e1809e9092e09aa239bc48ace41d51253179e635bb/PySide2-5.15.0-5.15.0-cp35.cp36.cp37.cp38-abi3-manylinux1_x86_64.whl
Resolving files.pythonhosted.org (files.pythonhosted.org)... 2a04:4e42:50::319, 151.101.201.63
Connecting to files.pythonhosted.org (files.pythonhosted.org)|2a04:4e42:50::319|:443... connected.
Unable to establish SSL connection.
https://github.com/altendky/qtrio/pull/114/checks?check_run_id=925825870 (below)
|
Cross-linking pypa/pip#8734. The reporter said the issue seems to happen right after they upgraded to pip 20.2, which seems to match the timeline (20.2 was released one day after this issue was reported). |
Can we close this as an issue in |
I would attribute this to unstableness of the CDN. Neither pip nor warehouse seemed to have done anything wrong. Neither has done anything about the issue, but there had not been similar reports for quite a while. |
@uranusjr Why is pip trying to hash-check an incomplete download here? Does that behavior still exist? |
I don’t think pip does hash-checks incomplete downloads, the problem is more like the CDN provided it broken downloads that seem complete from pip’s perspective. |
I don't know enough about http/ssl/etc to claim there is an issue or know what it would be, but it does strike me as odd that pip can provide a progress bar, stop at 20%, and conclude the download is complete. Odd, of course, is not proof it is wrong though. |
Since pypa/pip#8734 is closed I'll close this as well & chalk this up to occasional CDN instability. |
Describe the bug
PyQt5 and PySide2 wheels sometimes fail pip's hash check even when I didn't specify any hash for them to match. I started observing this in GitHub Actions CI a few days back and then once in the triggered Read the Docs build as well. I subsequently recreated it locally by just putting an install in a loop. I'll ballpark the frequency at one in a hundred installs failing. While I didn't notice the progress stopping well before the file should be complete in CI (I assume it wasn't showing at all) it does show up in the local runs I did.
I have no basis for guessing whether this is a warehouse/PyPI issue or pip but reporting here was suggested in
#pypa
.https://gist.github.com/altendky/43727125a9585025143f218401c9ade4#file-gistfile1-txt-L165-L174
full output
Expected behavior
pip install x
'never' results in a hash error. (yeah, never say never but still...)To Reproduce
My Platform
The text was updated successfully, but these errors were encountered: