-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore adding static typing #10865
Comments
mypy has configuration options that would allow doing that gradually https://mypy.readthedocs.io/en/stable/config_file.html We could either include paths that got converted or exclude those that do not (this would require all new ones to already be typed) |
I'm interested in this kind of work. A few questions/decisions arise at this juncture:
|
I think this belongs with our linters.
There are some existing types that @fizyk did that could be a good starting point. Other good starting points would be our more critical codepaths.
Using |
I think this can be closed now, as we have a mechanism for adding more types as gradually as we want to now. |
We should determine a way that we can gradually add static typing (and ensure that we're able to assert that it is correct in CI) without introducing a single massive PR.
The text was updated successfully, but these errors were encountered: