Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate extinction correction from sensitivity function #1777

Open
rcooke-ast opened this issue Feb 22, 2024 · 0 comments
Open

Separate extinction correction from sensitivity function #1777

rcooke-ast opened this issue Feb 22, 2024 · 0 comments

Comments

@rcooke-ast
Copy link
Collaborator

rcooke-ast commented Feb 22, 2024

When combining standard star exposures, the extinction correction should be applied on each individual observation. A note that was introduced in PR #1770:

The extinction correction cannot currently be done in the datacube creation because the sensitivity function algorithms correct the standard star for extinction when generating the sensitivity function. Including the extinction correction in the datacube would result in a double correction of the standard star for extinction. This could be wrong when combining multiple standard star exposures if the airmass of the standard star exposures is significantly different. For now, to stay consistent with the current pipeline, the extinction correction is done in the sensitivity function algorithms, with the caveat that the standard star exposures are assumed to have similar airmasses. For now, comment out the extinction correction, and reapply this later when the sensitivity function algorithms are unified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant