Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved scattered light model #1684

Closed
rcooke-ast opened this issue Sep 27, 2023 · 2 comments
Closed

Improved scattered light model #1684

rcooke-ast opened this issue Sep 27, 2023 · 2 comments
Assignees

Comments

@rcooke-ast
Copy link
Collaborator

At the moment a very crude model of the scattered light is implemented, and this is only used for KCWI reductions. Ideally, we should use the inter-order regions (for Echelle reductions) and the interslice region for SlicerIFU reductions. This enhancement would require that we pass the Slits calibration files into rawimage.py (because the scattered light should be removed before the flatfielding frames), and this is not currently well setup for this.

The current simplistic model for scattered light subtraction (at least for KCWI) was implemented in PR #1661. I assign myself to look into a better model for KCWI. Part of this effort should involve using the Slits information.

@kbwestfall
Copy link
Collaborator

Partially addressed by #1704 . @rcooke-ast , can you comment on what's left to do?

@rcooke-ast
Copy link
Collaborator Author

Yes, this is now "fully" addressed. KCRM is not implemented, but KCWI and ESI are both implemented. So, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants