This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: export alembic start/end frame type #254
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
We interpret frame as int, but queries in Maya ofter return frames as float. This bug happens in
extract_animation.pywhen handles are 0. Then frame range is picked from context (where it is as int) andpype.hosts.maya.lib.extract_alembic()asserts will fail as they are expecting float from Maya.Fix
Fix is casting explicitly frames to float before passing them to
extract_alembic().