Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

fix(nks): duplicity in hierarchy tag and not matching names clips #130

Merged
merged 1 commit into from
May 20, 2020

Conversation

jakubjezek001
Copy link
Member

  • check if hierarchy tag is not on two clips above each other
  • check if two clips above each other are having the same name

@jakubjezek001 jakubjezek001 self-assigned this May 7, 2020
@jakubjezek001 jakubjezek001 requested a review from mkolar May 7, 2020 17:49
@jakubjezek001 jakubjezek001 added affects: USER type: bug Something isn't working labels May 7, 2020
file_head = source.filenameHead()
file_info = next((f for f in source.fileinfos()), None)
source_first_frame = file_info.startFrame()
is_sequence = False

self.log.debug(
"__ assets_shared: {}".format(context.data["assetsShared"]))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@jakubjezek001 jakubjezek001 linked an issue May 7, 2020 that may be closed by this pull request
@mkolar
Copy link
Member

mkolar commented May 12, 2020

I can't quite see from the code what exactly was the problem. can you describe what is is fixing?

@mkolar
Copy link
Member

mkolar commented May 13, 2020

seems to be merged into #144 Please close this if that is the case, it's quite confusing

@mkolar mkolar merged commit 7ac7600 into develop May 20, 2020
@mkolar mkolar added this to the 2.9 milestone May 25, 2020
@mkolar mkolar deleted the bugfix/129-nks_coupe_small_fixes branch May 25, 2020 10:00
Tilix4 pushed a commit to Tilix4/OpenPype that referenced this pull request Jun 21, 2023
Tilix4 pushed a commit to Tilix4/OpenPype that referenced this pull request Aug 4, 2023
Tilix4 pushed a commit to Tilix4/OpenPype that referenced this pull request Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nks coupe small fixes
2 participants