This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plement-ass-extractor
…plement-ass-extractor
…tractor' into feature/OP-3924_implement-ass-extractor
antirotor
added
type: enhancement
Enhancements to existing functionality
host: Maya
labels
Dec 8, 2022
Task linked: OP-3924 Implement ASS Extractor |
This said, I would remove it from here because it will be much easier (again from the user perspective) to set it when we switch Maya to the new publisher. |
tokejepsen
approved these changes
Dec 8, 2022
m-u-r-p-h-y
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Reviewable ass extractor improvements.
Description
This is feature parallel to client extractor, with settings ported to OpenPype workflows with objectset and project settings.
Discussion
I don't agree with having an
exportSequence
attribute because in OpenPype workflows you can define frame range easily, so it makes more sense to just support single frame publishes (which it already does). I propose to remove this attribute to simplify code and workflow.So to note, current workflow of using current frame to export is prone to user errors and unpredictability.
Testing notes: