This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Resolve: updating to v18 compatibility #3986
Merged
+371
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to expose environment variables
jakubjezek001
added
host: Resolve
type: enhancement
|
Task linked: OP-4216 Conforming from Resolve18 |
|
Task linked: OP-4147 Davinci QT binding not found |
|
resolve #3911 |
iLLiCiTiT
reviewed
Oct 17, 2022
| @@ -14,35 +13,91 @@ class ResolvePrelaunch(PreLaunchHook): | |||
| app_groups = ["resolve"] | |||
|
|
|||
| def execute(self): | |||
| current_platform = platform.system().lower() | |||
|
|
|||
| PROGRAMDATA = self.launch_context.env["PROGRAMDATA"] | |||
There was a problem hiding this comment.
This will crash on linux or mac because they don't have PROGRAMDATA.
jrsndl
reviewed
Oct 18, 2022
jrsndl
approved these changes
Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Resolve is now supported up to v18
Description
Latest version v18 is supporting Python installation for higher then 3.6. We have been testing it on version 3.9.13. OpenTimelineIO is working without glitch at version 0.15.
Additional info
Testing notes:
openpype\hosts\resolve\README.markdownfor installation of OpenTimelineIO and PySide2