-
Notifications
You must be signed in to change notification settings - Fork 129
Maya: Refactor submit deadline to use AbstractSubmitDeadline #3759
Maya: Refactor submit deadline to use AbstractSubmitDeadline #3759
Conversation
…itDeadline` base. - This does *NOT* work currently!
…line_abstract_base
@@ -293,6 +293,7 @@ def process(self, context): | |||
"source": filepath, | |||
"expectedFiles": full_exp_files, | |||
"publishRenderMetadataFolder": common_publish_meta_path, | |||
"renderProducts": layer_render_products, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not JSON serializable and thus the logging below had to be removed to avoid an error. Is this a problem?
- To improve readability of code that sets the values
This way it matches more with logic of other host submitters (e.g. AfterEffects + Harmony)
openpype/modules/deadline/plugins/publish/submit_maya_deadline.py
Outdated
Show resolved
Hide resolved
|
||
plugin_info_ext = { | ||
# Renderer | ||
plugin_info = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just note that we should probably move all those to the similar class like MayaPluginInfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are actually PluginInfo for different plug-ins across the file. So this is one for the Tile Assembler, others I believe are for VRay plugin and Arnold plugin. But yes, it'd be more consistent if each would get their own plugin info accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now refactored them to their own PluginInfo data classes - I wonder if that's more readable now. It feels a lot cleaner like this.
so far it looks very good, I would like to go over it and remove form it ass and vrscene exporting jobs because I don't think they currently work and it will clean up the code. |
I'm fine with removing it. However, might be more work to add them again later instead of fixing now? Thoughts? |
OutputFilenameTile = attr.ib(factory=partial(DeadlineIndexedVar, | ||
"OutputFilename{}Tile")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone know of a better more pythonic way to initialize these with attr
? I feel like I'm missing something obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kalisp or @antirotor do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works in AE.
Thank you very much - that was a bug! Fixed with 49dff63 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brief description
Refactor submit deadline to use AbstractSubmitDeadline.
Description
Current state is functional in that it's able to do a straight maya submission (and I was able to submit a Tile Render submission, but haven't tested whether the tile assembly came out as needed yet).
I'll leave as "Draft" for the time being as I expect to still perform some fixes on my end that I can probably test easily soon.
Additional info
Yes, this is a massive PR and likely breaks on many things - but I wanted to start raising discussions on approach. I can try to separate into standalone smaller PRs that first cleanup the old submitter and then refactor - but there will always be a tipping point where it needs to be refactored to the new logic and we'll still need to end up testing the new functionality. Thus I feel it might be worth just cleaning the monster ones and test thoroughly the different cases.
Especially because likely many cases (Tile Rendering, V-Ray submissions, Arnold submissions) were previously untested in their latest state too and might have been broken for some time.
Testing notes: