This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Move publish utils to pipeline #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errored_plugins_from_context' into openpype.pipeline.publish
…d_instances_from_context'
…m_context' as deprecated in 'openpype.action'
|
Task linked: OP-3835 Move publish utils to pipeline |
iLLiCiTiT
added
the
type: refactor
iLLiCiTiT
requested review from
antirotor,
64qam,
jakubjezek001,
kalisp,
m-u-r-p-h-y and
mkolar
|
Maya works as expected, the order is correct and publish was successful
|
m-u-r-p-h-y
previously requested changes
Aug 30, 2022
There was a problem hiding this comment.
there is an issue with Houdini
Traceback (most recent call last):
File "<stdin>", line 5, in <module>
File "D:\REPO\OpenPype\openpype\tools\utils\host_tools.py", line 398, in show_creator
_SingletonPoint.show_tool_by_name("creator", parent)
File "D:\REPO\OpenPype\openpype\tools\utils\host_tools.py", line 364, in show_tool_by_name
cls.helper.show_tool_by_name(tool_name, parent, *args, **kwargs)
File "D:\REPO\OpenPype\openpype\tools\utils\host_tools.py", line 324, in show_tool_by_name
self.show_creator(parent, *args, **kwargs)
File "D:\REPO\OpenPype\openpype\tools\utils\host_tools.py", line 118, in show_creator
creator_tool.refresh()
File "D:\REPO\OpenPype\openpype\tools\creator\window.py", line 372, in refresh
self._asset_name_input.setText(legacy_io.Session["AVALON_ASSET"])
KeyError: 'AVALON_ASSET'
Unrelated to this PR but it seems like a bug for houdini 19.5 EDITED: Will be fixed in #3697 |
iLLiCiTiT
dismissed
m-u-r-p-h-y’s stale review
Change Request is not related to this PR
|
Houdini works as expected
|
|
@BigRoy can you please check this PR for Fusion pls? I suppose you have the one available . . . thx! |
64qam
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Moved publish utils from
openpype.pluginandopenpype.actionintoopenpype.pipeline.publish.Description
Kept full backwards compatibility. Moved helper functions
get_errored_plugins_from_data,get_errored_instances_from_contextandcontextplugin_should_run. Moved simple repair actionsRepairActionandRepairContextAction. Removed unused exceptionValidationException. Also moved order variablesValidatePipelineOrder,ValidateContentsOrder,ValidateSceneOrderandValidateMeshOrder.Replaced all imports in current codebase to use new locations and marked (what was possible) as deprecated.
Additional notes
If it is untestable I can split this PR into more smalled PRs e.g. per host.
Testing notes: