Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Photoshop: Defined photoshop as addon #3736

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Photoshop host is addon.

Description

Implemented PhotoshopAddon for photoshop host which gives public information about the host.

Testing notes:

  • Photoshop can be launched and integration works (as before)

@ynbot
Copy link
Contributor

ynbot commented Aug 25, 2022

Task linked: OP-3777 Photoshop as addon

@iLLiCiTiT iLLiCiTiT added host: Photoshop type: refactor Structural changes not affecting functionality labels Aug 25, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Aug 25, 2022
@iLLiCiTiT iLLiCiTiT requested review from 64qam and kalisp August 25, 2022 14:25
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After starting in Launcher:

  - { ApplicationLaunchContext-2021 }: [  Discovery of launch hooks started.  ]
  - { ApplicationLaunchContext-2021 }: [ Paths searched for launch hooks:
- C:\Users\qam\pypeclub\OpenPype\openpype\hooks
- C:\Users\qam\pypeclub\OpenPype\openpype\modules\ftrack\launch_hooks
- C:\Users\qam\pypeclub\OpenPype\openpype\modules\timers_manager\launch_hooks ]
  - { ApplicationLaunchContext-2021 }: [  Skipped hook invalid for current launch context: LaunchFoundryAppsWindows  ]
  - { ApplicationLaunchContext-2021 }: [  Skipped hook invalid for current launch context: LaunchWithTerminal  ]
  - { ApplicationLaunchContext-2021 }: [  Found 5 prelaunch and 2 postlaunch hooks.  ]
  - { ApplicationLaunchContext-2021 }: [  Executing prelaunch hook: GlobalHostDataHook  ]
  - { GlobalHostDataHook }: [  Project name is set to "qam"  ]
  - { GlobalHostDataHook }: [  Adding Python version specific paths to PYTHONPATH  ]
  - { GlobalHostDataHook }: [  Will add environments for apps and tools: mtoa, 2021, photoshop, 3-1  ]
WARNING:openpype.tools.launcher.window.LauncherWindow:Action launch failed.
Traceback (most recent call last):
  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\launcher\window.py", line 411, in run_action
    action().process(filtered_session)
  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\launcher\actions.py", line 115, in process
    **self.data
  File "C:\Users\qam\pypeclub\OpenPype\openpype\lib\applications.py", line 363, in launch
    return self.manager.launch(self.full_name, *args, **kwargs)
  File "C:\Users\qam\pypeclub\OpenPype\openpype\lib\applications.py", line 503, in launch
    return context.launch()
  File "C:\Users\qam\pypeclub\OpenPype\openpype\lib\applications.py", line 1167, in launch
    prelaunch_hook.execute()
  File "C:\Users\qam\pypeclub\OpenPype\openpype\hooks\pre_global_host_data.py", line 43, in execute
    prepare_app_environments(temp_data, self.launch_context.env_group)
  File "C:\Users\qam\pypeclub\OpenPype\openpype\lib\applications.py", line 1501, in prepare_app_environments
    module = __import__("openpype.hosts", fromlist=[app.host_name])
  File "C:\Users\qam\pypeclub\OpenPype\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "C:\Users\qam\pypeclub\OpenPype\openpype\hosts\photoshop\__init__.py", line 1, in <module>
    from .module import (
  File "C:\Users\qam\pypeclub\OpenPype\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
ModuleNotFoundError: No module named 'openpype.hosts.photoshop.module'```

@iLLiCiTiT
Copy link
Member Author

After starting in Launcher

Should be fixed

@iLLiCiTiT iLLiCiTiT merged commit 0bc5dfa into develop Aug 26, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3777_Photoshop-as-addon branch August 26, 2022 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Photoshop type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants