-
Notifications
You must be signed in to change notification settings - Fork 129
Scene Inventory: Add subsetGroup column #3658
Scene Inventory: Add subsetGroup column #3658
Conversation
@@ -88,7 +88,8 @@ def __init__(self, parent=None): | |||
view.setColumnWidth(1, 55) # version | |||
view.setColumnWidth(2, 55) # count | |||
view.setColumnWidth(3, 150) # family | |||
view.setColumnWidth(4, 100) # namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Namespace column didn't exist - this was actually setting the loader
column. I felt the default width for the loader column was slightly too small and most loader names got cut off. So I've set the loader column width to 150.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok and works. Can someone check it from UX perspective ( @mkolar @antirotor )?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally just name it Group
rather than subsetGroup
.
In general It's a good idea, however it's becoming painfully obvious that we'll need to implement hiding and unhiding of columns. For example most of clients on support don't actually use this grouping that much and for those it's suddenly and empty column that's there all the time and is never really populated. Hence needless confusion.
That's more food for though though and I'm happy with merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please tweak the name of the column, then we can merge
@mkolar How about solely updating the header column's name but keeping it the same in the code? :) Somehow I feel I'm fine either way. EDIT: Actually - let's just do as you say. We can always clarify if code becomes unclear at some point. |
Co-authored-by: Milan Kolar <[email protected]>
@mkolar are you ok with current state? |
Brief description
This adds a
subsetGroup
column to the Scene Inventory / Manager.Description
We tend to group publishes in the Loader (shortcut:
ctrl + g
) to sometimes label things as "extras" or even group them to be "deprecated".By showing the column in the Manager this is now also much easier to trace to that information.
Additional info
Code might be a bit messy - so please double check.
The "icon" for the group is the default group icon. Originally in Avalon groups could be configured on the project to allow custom icons per groups, etc. but that's currently not supported in OpenPype as far as I know. Thus I had chosen for now to just hardcode the icon.
This would be extra useful as soon as better UX for filtering is added to tools - then we could also filter by subset group, etc.
Testing notes: