-
Notifications
You must be signed in to change notification settings - Fork 129
Resolve: Match folder structure to other hosts #3653
Resolve: Match folder structure to other hosts #3653
Conversation
work_root | ||
) | ||
|
||
from .testing_utils import TestGUI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
PublishClip | ||
) | ||
|
||
from .workio import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
|
||
from .menu import launch_pype_menu | ||
|
||
from .plugin import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
get_reformated_path | ||
) | ||
|
||
from .menu import launch_pype_menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
list_instances | ||
) | ||
|
||
from .lib import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
get_resolve_module | ||
) | ||
|
||
from .pipeline import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
API_DIR = os.path.dirname(os.path.abspath(__file__)) | ||
HOST_DIR = os.path.dirname(API_DIR) | ||
PLUGINS_DIR = os.path.join(HOST_DIR, "plugins") | ||
from .utils import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module level import not at top of file
I would love to check, but I am not able to make the Resolve work. Attempt to run Openpype_Menu script stops at importing OTIO:
Resolve 17.4.6 build 4 |
You have to install OpenTimelineIO separately into p3.6. The process should be explained in documentation I believe. |
@iLLiCiTiT please also fix the pep8 before the merge ;) |
I can't. It's because the imports are after definition of |
Brief description
Make sure that code related to in-DCC logic is not imported in main host directory. This change gives ability to have resolve as module which is not possible at the moment.
Description
Changed all import to point directly to function locations or to
openpype.hosts.resolve.api
instead ofopenpype.hosts.resolve
. Movedsetup
function from in-DCC functions to public code because is used in prelaunch hook.Additional info
I don't have resolve so all changes are made blindly, please report any issues. Current structure would block development of some features thus this changes are needed to move on.
There is a lot of script files that seems to be duplicated or not used, we should consider remove those unused.
Testing notes:
Resolves #3406