This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it should look there
…n is passed to 'collect_launch_hook_paths
Task linked: OP-3314 Hosts as Addons step 1 |
iLLiCiTiT
added
the
type: refactor
Structural changes not affecting functionality
label
Aug 11, 2022
iLLiCiTiT
requested review from
64qam,
antirotor,
kalisp,
m-u-r-p-h-y and
mkolar
August 11, 2022 12:48
m-u-r-p-h-y
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mkolar
approved these changes
Aug 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Hosts are OpenPype modules so they have more abilities and more defined structure.
Description
First step to be able define hosts as OpenPype modules which can make them self contained parts. Added interface
IHostModule
which marks a module as host module so it can handle host related logic before a DCC or process, where host is integrated, is running. Host module must have set which host it represents with it name (host_name
). Can define it's workfile extensions out of integration so it's available before DCC is running. As module it can handle some logic more dynamically without predetermined paths. For example can define path to launch hooks usingget_launch_hook_paths
or handle launch environments implementingadd_implementation_envs
as module method.Changed how paths to prelaunch hooks are received. An object of application which is launched is passed as an argument to
get_launch_hook_paths
so it is possible to filter out if it make sense to add certain launch hook paths for passed application. Module does not have to inherit fromILaunchHookPaths
to be able define launch hooks.To demonstrate the functionality a maya implementation is now used as module.
Testing notes: