This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Ftrack: Add more metadata to ftrack components #3612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Add more metadata to ftrack components even for those which are not for review.
Description
Add fps, width, height to components that can potentially be able to use it in CineCync. To achieve that I'm using ffprobe to read information about published path. If ffprobe crashes the component won't have any metadata otherwise fps (or
frameRate
is added.Fixed issue when there are both
ftrackreview-mp4
andftrackreview-image
which could cause the thumbnail is showed in play instead of video. When both are available theftrackreview-image
is renamed to thumbnail.Additional information
We have no information about representation, is it an image or video with width, height and fps and sometimes when the information is there it is sometimes copied from source representation which changed so the data are not relevant.
Testing notes:
frameRate
,width
andheight
(workfile probably won't)