-
Notifications
You must be signed in to change notification settings - Fork 129
AfterEffects: refactored integrate doesnt work formulti frame publishes #3610
AfterEffects: refactored integrate doesnt work formulti frame publishes #3610
Conversation
New publisher expects frames in file names in '.0000.' format, AE by default provides ('_0000.'). Locally rendered files need to be renamed to appropriate format.
Previous test published only single frame, didn't catch issue in new integrate.
New publisher requires main family as 'render', so there will be need to skip 'render.farm' which should not be integrated during initial publish. (Currently only affecting AE.)
@@ -167,7 +167,7 @@ class IntegrateAsset(pyblish.api.InstancePlugin): | |||
skip_host_families = [] | |||
|
|||
def process(self, instance): | |||
if self._temp_skip_instance_by_settings(instance): | |||
if self.skip_instance_by_settings(instance): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the rename?
That was removed on purpose and was replaced by having BTW: Current settings for that won't cause that instance is not integrated but will cause that legacy integrator is used instead. |
With PR #3611 this PR is not needed |
…farm" This reverts commit ef60744 Not necessary, better to use `instance.data["farm"]`
No Settings necessary, instance itself should hold if it is targetted for farm (eg. not locally integrated.)
…-3684_Refactored-integrate-doesnt-work-for-AE-multi-frame-publishes
This PR is still useful for new testing class and for farm publishes. |
Brief description
Frame pattern used in new integrate is not catching frames pattern in AE
Description
Locally rendered files are renamed into frame pattern that integrator plugin understands.
Additional info
(Added Kuba and Ondrej as reviewers to only highlight this.)Added
render.farm
for AE into Settings to skip integrating. New publisher should have 'render' as a primary family (and 'render.farmin families), which would trigger integrating (legacy integrator has 'render.farm' in
exclude_families` , this functionality is currently missing in refactored integrator).I think we should keepskip_host_families
not as a temporary solution to broken publishes for new integrator, but use it instead of 'exclude_families' which might be always useful.Testing notes: