This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: Fix animated attributes (ie. overscan) on loaded cameras breaking review publishing. #3562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Fixes #2807 by checking for locked attributes and skipping them.
Description
Issue #2807 stems from published cameras being unable to distinguish animated attributes on them when they're published as alembics, so when they're loaded in again, the attributes are automatically connected to the alembic nodes. This solves that issue by testing if the attribute is locked and passes changing those attributes if they're connected.
Additional info
It's mainly handled in
capture.py
, with the soft fail wrapper by @kalisp included in case Maya acts up.Testing notes:
Should run smoothly as opposed to breaking during the extract playblast stage.