Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

NewPublisher: Groups work and enum multivalue #3501

Merged
merged 8 commits into from
Jul 15, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Instances refresh use right source for groups and enum attribute can handle multivalue.

Description

Groups on update of instance were still using old implementation. And enum multivalue didn't work because combobox did not have line edit available.

Testing notes:

Change view few times after instance creation.

  • it should not crash and should use right groups

Select multiple instances which have defined enumerator attribute.

  • it should not crash and < Multivalue > should be showed as label if instances have different values

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 12, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jul 12, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the screenshot gif please. It seems to have a bug still.
traypublisherv03

First multiselection is showing enumerator with first position of option.
Secondly it is still active on arrow click only to uncollapse the items to offer.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!

@iLLiCiTiT iLLiCiTiT merged commit 31bae28 into develop Jul 15, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/new_publisher_minor_fixes branch July 15, 2022 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants