This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Enhancement: More control over thumbnail processing. #3259
Merged
jakubjezek001
merged 39 commits into
develop
from
OP-3172_More-control-over-thumbnail-processing
Jun 15, 2022
Merged
Enhancement: More control over thumbnail processing. #3259
jakubjezek001
merged 39 commits into
develop
from
OP-3172_More-control-over-thumbnail-processing
Jun 15, 2022
+104
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
May 27, 2022
Task linked: OP-3172 More control over thumbnail processing |
ghost
marked this pull request as draft
May 27, 2022 06:47
BigRoy
changed the title
Enhancemet: More control over thumbnail processing.
Enhancement: More control over thumbnail processing.
May 27, 2022
|
Thank you @iLLiCiTiT I appreciate the thorough reply! Will get on that right away! |
antirotor
previously requested changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments... Couldn't test it currently because of unrelated bugs, but otherwise it looks ok.
This was
linked to
issues
Jun 7, 2022
iLLiCiTiT
reviewed
Jun 8, 2022
iLLiCiTiT
reviewed
Jun 9, 2022
iLLiCiTiT
reviewed
Jun 9, 2022
iLLiCiTiT
reviewed
Jun 9, 2022
Co-authored-by: Jakub Trllo <[email protected]>
…s://github.com/pypeclub/OpenPype into OP-3172_More-control-over-thumbnail-processing
iLLiCiTiT
reviewed
Jun 10, 2022
iLLiCiTiT
reviewed
Jun 10, 2022
Co-authored-by: Jakub Trllo <[email protected]>
Co-authored-by: Jakub Trllo <[email protected]>
…s://github.com/pypeclub/OpenPype into OP-3172_More-control-over-thumbnail-processing
64qam
approved these changes
Jun 14, 2022
jakubjezek001
approved these changes
Jun 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Add specific control for processing of thumbnails.
Description
Improve control over processing of thumbnails using profiles to indicate hosts and tasks.
Fixes a bug (Should fix Issue #2843), handles files with arbitrary size processing in through setting
max_int
as an FFMPEG flag, as well as handling video files through FFMPEG specifically, and image files through OpenImageIO utility.Additional info
Some refactoring is done to check for specific file format within the representation in order to specify which tool is used for the thumbnail creation (to reduce probability of errors).