Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

SiteSync: fix transitive alternate sites, fix dropdown in Local Settings #3018

Merged
merged 5 commits into from
Apr 8, 2022

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Apr 6, 2022

Brief description

Based on specific use case for a customer where separate site is used for specific project.

Description

'studio2' site was created to separate synchronization for specific project, previous implementation didn't handle setting this site as an alternative site to studio.

Testing notes:

  1. this PR will be tested by customer on their specific configuration
  2. It should be tested on regular configuration if it didn't break anything (just pulled and start OP and try to publish something if it behaves same way as before)

Implements recursive relationship between alternative sites
Without this Tray configuring background process will not show proper site in LS dropdown
@kalisp kalisp added type: bug Something isn't working module: Sitesync labels Apr 6, 2022
@kalisp kalisp requested a review from m-u-r-p-h-y April 6, 2022 10:50
@kalisp kalisp self-assigned this Apr 6, 2022
@kalisp
Copy link
Member Author

kalisp commented Apr 8, 2022

It is working for customer.


return rec
for alt_alt_site in alt_site_pairs.get(alt_site, []):
if ( alt_alt_site != site_name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with hound

@kalisp kalisp requested a review from iLLiCiTiT April 8, 2022 10:32
@kalisp kalisp merged commit 92bf8d0 into develop Apr 8, 2022
@mkolar mkolar added this to the next milestone Apr 11, 2022
@kalisp kalisp deleted the bugfix/fix_alternate_sites branch April 13, 2022 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Sitesync type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants