This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Console Interpreter: Changed how console splitter size are reused on show #3016
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigRoy
reviewed
Apr 5, 2022
BigRoy
reviewed
Apr 5, 2022
Comment on lines
+643
to
+644
| splitter_size_ratio = self._splitter_size_ratio | ||
| self._splitter_size_ratio = None |
There was a problem hiding this comment.
It does seem weird that we're storing this value to self just so it's used this one time on first show and only then. I understand the init_from_registry() takes all settings from registry but nonetheless this feels odd.
There was a problem hiding this comment.
It does seem weird that we're storing this value to self just so it's used this one time on first show and only then.
I agree but at the same time loading the data from registry twice is weirder. Since splitter sizes must be set after show and window resize must happen before show, it's just decision.
Co-authored-by: Roy Nieterau <[email protected]>
64qam
approved these changes
Apr 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Use stored splitter sizes as relative ratio rather then absolute size.
Description
Restored sizes are now set explicitly on initialization but the size of window is not yet known so the bottom part is squeezed and when sizes would be set as absolute size of first show it may cause issues when machine has more displays with different resolution. The best solution seems to be se restore size of window before first show and change splitter sizes after showing up.
Testing notes: