This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Fix - remove doubled dot in workfile created from template #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64qam
approved these changes
Apr 1, 2022
BigRoy
reviewed
Apr 1, 2022
| @@ -1965,6 +1965,7 @@ def get_last_workfile( | |||
| data.pop("comment", None) | |||
| if not data.get("ext"): | |||
| data["ext"] = extensions[0] | |||
| data["ext"] = data["ext"].replace('.', '') | |||
There was a problem hiding this comment.
This sounds like a "hack" to fix another issue. The fill data shouldn't have a . to begin with.
This logic now breaks usages of ext where the actual extension also contains a dot, like .ass.gz.
If we'd want to ensure ext never starts with a dot, fine with me. We could raise an error so that whenever it happens we can fix the root of the problem where fill data got the wrong information. Right?
Ah, nevermind. This is only for the workfile so doesn't cover the .ass.gz case it seems. Still this sounds like a workaround to another problem?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Newly created workfile contained 2 dots before extension