This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Flame: support for comment with xml attribute overrides #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/OP-2731_Flame-rendering-presets-resolution-and-regex-comment-filter
jakubjezek001
added
host: Flame
iLLiCiTiT
reviewed
Mar 16, 2022
openpype/hosts/flame/plugins/publish/collect_timeline_instances.py
Outdated
Show resolved
Hide resolved
…esolution-and-regex-comment-filter
parsed attributes from comments can be ignored now
iLLiCiTiT
reviewed
Mar 17, 2022
openpype/hosts/flame/plugins/publish/collect_timeline_instances.py
Outdated
Show resolved
Hide resolved
…s.py Co-authored-by: Jakub Trllo <[email protected]>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| # get pattern defined by type | ||
| pattern = TXT_PATERN | ||
| if a_type in ("number" , "float"): |
iLLiCiTiT
approved these changes
Mar 17, 2022
jakubjezek001
deleted the
feature/OP-2731_Flame-rendering-presets-resolution-and-regex-comment-filter
branch
mkolar
removed
the
type: feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Supporting timeline segment comments with xml overrides.
Description
Client was requesting multiple resolution with custom values to be used during exporting in publish. This could only by supported by some sort of input values and segment's comment is the best way to do it as it is supporting multiple selected segments' input. The supported syntax is described lower.
Additional info
We are supporting following attributes: width, height, pixelAspect, resizeType, resizeFilter and additionally also resolution (with multiple input string >> 1920x1080x1.5). User can add to the segment comment following text:
resolution: 1920x1080x1.5; resizeType: filland it will be resolved to:This will be dynamically added to xml preset override before the the sequence will be processed. It will be also set on resolutionWidth, resolutionHeight, pixelRatio on a shot/asset data.
dependencies
this PR is based on #2869