Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Move Unreal Implementation to OpenPype #2823

Merged
merged 11 commits into from
Mar 1, 2022

Conversation

antirotor
Copy link
Member

Changes

This is moving host specific logic from Avalon to OpenPype. It is removing integration plugin as submodule and adding it directly to Unreal host implementation. That plugin was "rebranded" to OpenPype.

To test successful move, create new Unreal project and go over basic functions to ensure it is working.

@antirotor antirotor requested a review from iLLiCiTiT March 1, 2022 12:36
@antirotor antirotor self-assigned this Mar 1, 2022
@mkolar
Copy link
Member

mkolar commented Mar 1, 2022

@simonebarbieri
Copy link
Contributor

I'm getting this error when trying to launch Unreal from a new task (no existing project for the task):

WARNING:openpype.lib.python_module_tools:Failed to load path: "C:\Dev\pype\simonebarbieri-pype\openpype\hosts\unreal\hooks\pre_workfile_preparation.py"
Traceback (most recent call last):
  File "C:\Dev\pype\simonebarbieri-pype\openpype\lib\python_module_tools.py", line 91, in modules_from_path
    module = import_filepath(full_path, mod_name)
  File "C:\Dev\pype\simonebarbieri-pype\openpype\lib\python_module_tools.py", line 36, in import_filepath
    module_loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "C:\Dev\pype\simonebarbieri-pype\openpype\hosts\unreal\hooks\pre_workfile_preparation.py", line 13, in <module>
    from openpype.hosts.unreal.api import lib as unreal_lib
  File "C:\Dev\pype\simonebarbieri-pype\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "C:\Dev\pype\simonebarbieri-pype\openpype\hosts\unreal\api\__init__.py", line 11, in <module>
    from .pipeline import (
  File "C:\Dev\pype\simonebarbieri-pype\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
  File "C:\Dev\pype\simonebarbieri-pype\openpype\hosts\unreal\api\pipeline.py", line 5, in <module>
    import unreal  # noqa
  File "C:\Dev\pype\simonebarbieri-pype\vendor\python\shiboken2\files.dir\shibokensupport\__feature__.py", line 142, in _import
    return original_import(name, *args, **kwargs)
ModuleNotFoundError: No module named 'unreal'

@antirotor antirotor requested a review from iLLiCiTiT March 1, 2022 14:47
Copy link
Contributor

@simonebarbieri simonebarbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried creating a new project, loading and updating some assets, and it seems to be working fine!

@antirotor antirotor merged commit 23fd830 into develop Mar 1, 2022
@antirotor antirotor deleted the enhancement/OP-2246-unreal_to_openpype branch March 1, 2022 15:36
@mkolar mkolar added the type: refactor Structural changes not affecting functionality label Mar 4, 2022
zhoub added a commit to zhoub/OpenPype that referenced this pull request Mar 14, 2022
zhoub added a commit to zhoub/OpenPype that referenced this pull request Mar 14, 2022
@mkolar mkolar added this to the 3.9.0 milestone Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: UE type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants