Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: fix fps validation popup #2685

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Validation of fps in maya will crash if does not match because can't import popup window.

Changes

  • fix popup import and add condition to show popup only if not in headless mode

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 9, 2022
@iLLiCiTiT iLLiCiTiT added host: Maya type: bug Something isn't working labels Feb 9, 2022
@iLLiCiTiT iLLiCiTiT changed the title fix fps validation popup Maya: fix fps validation popup Feb 9, 2022
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is another error popping up now:

# Warning: avalon.pipeline : Traceback (most recent call last):
  File "D:\REPO\OpenPype\repos\avalon-core\avalon\pipeline.py", line 631, in emit
    callback(*args)
  File "D:\REPO\OpenPype\openpype\hosts\maya\api\pipeline.py", line 503, in on_open
    lib.validate_fps()
  File "D:\REPO\OpenPype\openpype\hosts\maya\api\lib.py", line 2449, in validate_fps
    dialog = popup.Popup2(parent=parent)
  File "D:\REPO\OpenPype\openpype\widgets\popup.py", line 112, in __init__
    Popup.__init__(self, parent=parent, *args, **kwargs)
  File "D:\REPO\OpenPype\openpype\widgets\popup.py", line 38, in __init__
    geometry = self.calculate_window_geometry()
  File "D:\REPO\OpenPype\openpype\widgets\popup.py", line 137, in calculate_window_geometry
    screen = app.desktop().screenNumber(parent_widget)
AttributeError: 'PySide2.QtCore.QCoreApplication' object has no attribute 'desktop'
 # 

@iLLiCiTiT
Copy link
Member Author

there is another error popping up now:

Fixed

Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works now, fps dialogue (in case of wrong fps set) is popping up

@iLLiCiTiT iLLiCiTiT merged commit f278b89 into develop Feb 9, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/maya_fps_validation_popup_bug branch February 9, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants