-
Notifications
You must be signed in to change notification settings - Fork 129
TimersManager: Start timer post launch hook #2418
TimersManager: Start timer post launch hook #2418
Conversation
… data for passed context
Task linked: OP-1172 Start timer post launch hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its working.
I am just wondering if check for context (project_name, asset_name, task_name) shouldn't be part of the calling function. Is there any use case where context could be empty or would I add validation for context whenever I would like to use the start_timer_with_webserver
?
I don't think that there is a use case when client side could handle that in any way. I mean if you find out that context you want to use is invalid what will you do with that? But it does make sense to return "success" in response. And add validate context method but I would not call it automatically in |
Brief description
Currently only post launch hook starting timer is in Ftrack but it can be triggered using TimersManager.
Changes
"hierarchy"
in rest api call to start timerchange_timer_from_host
with static methodstart_timer_with_webserver
Resolves #1656