Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya : add option to not group reference in ReferenceLoader #2383

Conversation

BenoitConnan
Copy link
Contributor

Options added :

  • attach_to_root : wether or not a group should contain reference

name: Feature request
about: Suggest an idea for this project
title: Add options to ReferenceLoader
labels: enhancement
assignees: ''

Is your feature request related to a problem? Please describe.
When an asset is referenced, a group subsetasset:_GRP is created
For our workflow already using a root node with a special name this group is
redundant and even an annoyance.

Describe the solution you'd like
Loaders have the possibility to receive options yet none were developped for ReferenceLoader.
So the pull request is about adding "attach_to_root" as an option.
Option is set by default as True to keep legacy loader behaviour

Describe alternatives you've considered
Huu ... Making another ReferenceLoader not grouping ?

"attach_to_root" : wether or not a group should contain reference
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how it is supposed to work. Either it is missing options defined in:

https://github.com/Ellipsanime/OpenPype/blob/7e04079151479548daf15ec81768c454935c71d3/openpype/hosts/maya/api/plugin.py#L91-L104

Or perhaps it should be configurable via Settings?

@BenoitConnan
Copy link
Contributor Author

BenoitConnan commented Dec 10, 2021

I am not sure how it is supposed to work. Either it is missing options defined in:

https://github.com/Ellipsanime/OpenPype/blob/7e04079151479548daf15ec81768c454935c71d3/openpype/hosts/maya/api/plugin.py#L91-L104

Or perhaps it should be configurable via Settings?

Hi @antirotor,
I'm not sure to get what you meant.
Should i add a qargparse.Boolean to options of ReferenceLoader ?
If so then i can't help to notice that options of ReferenceLoader is never used anywhere.

Maybe i'm missing something ?

@antirotor
Copy link
Member

Maybe i'm missing something ?

what I meant was adding it here:
image

@BenoitConnan
Copy link
Contributor Author

BenoitConnan commented Jan 3, 2022

Oh, i see. I didn't know this was a thing. I was directly injecting loading with options. This is way better !

Well, it's changed now :)

@antirotor antirotor added the type: enhancement Enhancements to existing functionality label Jan 4, 2022
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!

@antirotor antirotor merged commit bc0b7f2 into ynput:develop Jan 4, 2022
@ClementHector ClementHector deleted the add-options-to-not-group-reference-for-referenceloader branch February 1, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Maya type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants