Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: Support multiple reviews #2271

Merged
merged 19 commits into from
Nov 22, 2021

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • rewritten plugin to easier find out thumbnail, review and others representations
  • first review representation is published as before
    • all following review representations will be published to different ftrack asset
    • ftrack asset name in that case is made up with concatenation of subset name and representation name

OpenPype 3 version of #1374

@mkolar
Copy link
Member

mkolar commented Nov 18, 2021

Task linked: OP-1969 Support multiple Ftrack reviews

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 18, 2021
@iLLiCiTiT iLLiCiTiT added module: Ftrack type: enhancement Enhancements to existing functionality labels Nov 18, 2021
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second reviewable doesn't get a thumbnail on ftrack so it looks like it's not working even though the review is there.
Secondly, I think we should Concatenate the names with _ it will be cleaner in the ftrack views

@iLLiCiTiT
Copy link
Member Author

I think we should Concatenate the names with _ it will be cleaner in the ftrack views

Fine for me

The second reviewable doesn't get a thumbnail on ftrack so it looks like it's not working even though the review is there.

I don't know how to pair thumbnail to review (but we definetely should have ability to do so).

@mkolar
Copy link
Member

mkolar commented Nov 19, 2021

I don't know how to pair thumbnail to review (but we definetely should have ability to do so).

well, you need to actually define it as a component on the version. We're already doing it for all reviewable media we upload.

@iLLiCiTiT
Copy link
Member Author

I've modified it

  • fixed bug for "other components" where component path was not set
  • not first reviews have ftrack asset name created with template {subset name}_{representation name}
  • not first reviews will duplicate thumbnail for the new asset

@iLLiCiTiT iLLiCiTiT merged commit b2f01d2 into develop Nov 22, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-1969_Support-multiple-Ftrack-reviews branch January 5, 2022 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Ftrack type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants