Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Enhance powershell build scripts #1827

Merged
merged 12 commits into from
Jul 15, 2022
Merged

Conversation

antirotor
Copy link
Member

@antirotor antirotor commented Jul 15, 2021

Enhancement

This feature is adding two PowerShell modules as submodules to enhance functionality and readability of windows powershell scripts and prepare path to extraction of common powershell code used across openpype build scripts to separate module.

Benefits:

  • BurntToast module allows outputting Notifications on Windows 10 (now it is notifying about completed build)
  • PSWriteColor module helps to reduce number of lines in scripts and increase readability.

Testing:

All .ps1 scripts should work as expected, you should have nice notification when build and venv creation are finished.

[cuID:yjx9dr]

@antirotor antirotor added type: enhancement Enhancements to existing functionality LOW labels Jul 15, 2021
@antirotor antirotor self-assigned this Jul 15, 2021
# Conflicts:
#	.gitmodules
#	tools/build.ps1
#	tools/build_win_installer.ps1
#	tools/create_zip.ps1
@mkolar
Copy link
Member

mkolar commented Apr 28, 2022

This got a bit stale. @antirotor is this reviewable?

@mkolar
Copy link
Member

mkolar commented Jul 13, 2022

@antirotor ping. How are we looking here?

@antirotor antirotor marked this pull request as ready for review July 13, 2022 15:46
@antirotor antirotor requested a review from 64qam July 13, 2022 15:49
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with the latest develop

@antirotor antirotor merged commit 1feae4a into develop Jul 15, 2022
@antirotor antirotor deleted the feature/powershell-enhancements branch July 15, 2022 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants