Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

hiero: precollect instances failing when audio selected #1743

Merged
merged 3 commits into from
Jun 23, 2021
Merged

hiero: precollect instances failing when audio selected #1743

merged 3 commits into from
Jun 23, 2021
+6 −6

Conversation

create-issue-branch[bot]
Copy link

@create-issue-branch create-issue-branch bot commented Jun 22, 2021 •
edited by jakubjezek001
Loading

closes #1740

Testing notes

  1. open hiero / workfile > create first version
  2. add movie with audio or image sequence with any wav file
  3. Create publishable clip (default values should work)
  4. select video clip and also audio clips (example image below)
  5. Publish and wait for all collectors to collect until the success (no error should appear on precollect intances as shown in the issue description)

image

@create-issue-branch create-issue-branch bot added type: bug Something isn't working sponsored Client endorsed or requested host: Hiero MEDIUM labels Jun 22, 2021
@jakubjezek001 jakubjezek001 marked this pull request as ready for review June 22, 2021 14:57
@jakubjezek001 jakubjezek001 requested a review from 64qam June 23, 2021 10:32
@64qam
Copy link
Member

64qam commented Jun 23, 2021

Still the same error as in the issue description

iLLiCiTiT
iLLiCiTiT approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

image

@jakubjezek001 jakubjezek001 removed the request for review from 64qam June 23, 2021 12:41
@jakubjezek001 jakubjezek001 merged commit 2db4e8a into develop Jun 23, 2021
@jakubjezek001 jakubjezek001 deleted the bugfix/1740-hiero-precollect-instances-failing-when-audio-selected branch June 23, 2021 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Hiero sponsored Client endorsed or requested type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hiero: precollect instances failing when audio selected
3 participants
@64qam @iLLiCiTiT @jakubjezek001