Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

'Delivery action' report fix + typos #1612

Merged
merged 4 commits into from
Jun 1, 2021
Merged

'Delivery action' report fix + typos #1612

merged 4 commits into from
Jun 1, 2021
+53 −27

Conversation

2-REC
Copy link
Contributor

@2-REC 2-REC commented May 31, 2021

Fixed errors:

  • Delivery action 'launch':
    • Result from 'real_launch' was not caught (report_items)
    • Invalid return types were used in case of skipped or empty data
  • 'check_destination_path':
    • When 'anatomy' path is not solved, only 1 error message is kept (second one replaces first one in case both errors occur)
  • Small typo corrections

@2-REC 2-REC changed the title 'Action delivery' report fix + typos 'Delivery action' report fix + typos May 31, 2021
@mkolar mkolar changed the base branch from main to develop May 31, 2021 08:08
@mkolar mkolar requested a review from kalisp May 31, 2021 08:19
iLLiCiTiT
iLLiCiTiT approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

kalisp
kalisp approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested, worked fine.

@mkolar mkolar added this to the 3.0.0 milestone Jun 1, 2021
@mkolar mkolar added the type: bug Something isn't working label Jun 1, 2021
@mkolar mkolar merged commit c8d0b1e into ynput:develop Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp approved these changes

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@2-REC @kalisp @iLLiCiTiT @mkolar