Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Keep metadata on remove overrides #1445

Merged
merged 3 commits into from
May 3, 2021
Merged

Keep metadata on remove overrides #1445

merged 3 commits into from
May 3, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented May 1, 2021 •
edited
Loading

Issue

Modifiable dict will remove labels from metadata on remove from studio/project overrides.

How to replicate

  1. open settings ui
  2. in system settings modify any input in tools
  3. show actions for tools and use Remove from studio default action
  4. Labels from tools should disappear

Changes

  • labels from metadata for the loaded state are set in remove overrides methods

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label May 1, 2021
@iLLiCiTiT iLLiCiTiT self-assigned this May 1, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team May 1, 2021 13:12
@mkolar mkolar merged commit 9f29e43 into develop May 3, 2021
@mkolar mkolar deleted the bugfix/keep_metadata_on_remove_overrides branch May 3, 2021 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar