-
Notifications
You must be signed in to change notification settings - Fork 129
Resolve: 17 compatibility issues and load image sequences #1422
Resolve: 17 compatibility issues and load image sequences #1422
Conversation
|
# activate resolve from openpype | ||
avalon.install(bmdvr) | ||
|
||
file_processing(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no newline at end of file
|
||
|
||
if __name__ == "__main__": | ||
path = "C:/CODE/__openpype_projects/jtest03dev/shots/sq01/mainsq01sh030/publish/plate/plateMain/v006/jt3d_mainsq01sh030_plateMain_v006.0996.exr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (148 > 79 characters)
dirname, file = os.path.split(fpath) | ||
_name, ext = os.path.splitext(file) | ||
print(dirname) | ||
media_pool_items = media_storage.AddItemListToMediaPool(os.path.normpath(dirname)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (90 > 79 characters)
clip_property = media_pool_item.GetClipProperty() | ||
clip_name = clip_property["File Name"] | ||
_clip_property = media_pool_item.GetClipProperty | ||
clip_name = _clip_property("File Name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local variable 'clip_name' is assigned to but never used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there was an optimization in V17 you will generally get faster response if you cherry pick the property of interest right away instead of getting all clip properties: clip_property = media_pool_item.GetClipProperty('File name')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have found out that in v17 None is returned if the GetClipProperty is on an audio clip and it was breaking other processes. This way it was more safe and if it is even faster than great.
so after @IgorRidanovic recomendation I had managed to fix the image sequence loading back to timeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
closes #1421
But I have found other new bugs on our code appearing after upgrading Resolve to last version at the moment 17.
I should admit that those api changes are realy frightening. There is no mention about this.