-
Notifications
You must be signed in to change notification settings - Fork 129
Nuke: deadline submission with search replaced env values from preset #1194
Nuke: deadline submission with search replaced env values from preset #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
Sorry, what is the use case for this? Thought we wanted to move towards explicit environment variables on Deadline submission to avoid implicit troubleshooting? |
This shouldn't make it into an official release. It is a situational patch for a client and we need to find a better way to deal with it in 3.0. the problem is that we need different environment values on certain keys, for jobs on the farm vs workstations. Normally we just send the workstation environments, but here it's simply not enough and some things need to be re-mapped. @jezscha I assume that the colourspace change, made it here by accident? that should be a second PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is a mix of two features, one of which should stay just in a local deployment. Let's split it please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
that had been reversed so this PR is holding only one feature fix. The other had been moved to #1199 |
Yes, you're right, I had enhanced the process. Thanks for reminding me ;) |
there might be a occasions where anyone would need to search replace any environment values. This will add ability to add dictionary with pairs to presets which are then iterated on each environment value.