Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: deadline submission with search replaced env values from preset #1194

Merged

Conversation

jakubjezek001
Copy link
Member

there might be a occasions where anyone would need to search replace any environment values. This will add ability to add dictionary with pairs to presets which are then iterated on each environment value.

@jakubjezek001 jakubjezek001 self-assigned this Mar 25, 2021
@jakubjezek001 jakubjezek001 added sponsored Client endorsed or requested host: Nuke hotfix labels Mar 25, 2021
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@tokejepsen
Copy link
Member

Sorry, what is the use case for this?

Thought we wanted to move towards explicit environment variables on Deadline submission to avoid implicit troubleshooting?

@mkolar
Copy link
Member

mkolar commented Mar 26, 2021

This shouldn't make it into an official release. It is a situational patch for a client and we need to find a better way to deal with it in 3.0.

the problem is that we need different environment values on certain keys, for jobs on the farm vs workstations. Normally we just send the workstation environments, but here it's simply not enough and some things need to be re-mapped.

@jezscha I assume that the colourspace change, made it here by accident? that should be a second PR

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is a mix of two features, one of which should stay just in a local deployment. Let's split it please

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@jakubjezek001
Copy link
Member Author

PR is a mix of two features, one of which should stay just in a local deployment. Let's split it, please

that had been reversed so this PR is holding only one feature fix. The other had been moved to #1199

@jakubjezek001
Copy link
Member Author

jakubjezek001 commented Mar 26, 2021

Sorry, what is the use case for this?
Thought we wanted to move towards explicit environment variables on Deadline submission to avoid implicit troubleshooting?

Yes, you're right, I had enhanced the process. Thanks for reminding me ;)

@mkolar mkolar self-requested a review March 31, 2021 07:30
@mkolar mkolar merged commit 3027801 into 2.x/main Mar 31, 2021
@mkolar mkolar deleted the 2.x/hotfix/nuke-deadline-env-path-replace-from-preset branch April 5, 2021 21:29
@mkolar mkolar added type: bug Something isn't working and removed hotfix labels Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke sponsored Client endorsed or requested type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants