Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition PyPy to PEP 3149 compliant SOABI tags #372

Closed
mattip opened this issue Aug 24, 2020 · 1 comment · Fixed by #373
Closed

Transition PyPy to PEP 3149 compliant SOABI tags #372

mattip opened this issue Aug 24, 2020 · 1 comment · Fixed by #373

Comments

@mattip
Copy link
Contributor

mattip commented Aug 24, 2020

It turns out PyPy's SOABI tag is not compliant with PEP 3149. Instead of containing both the ABI tag and the platform tag, PyPY's value returned for the SOABI query is only the ABI tag. For instance, on linux 64 CPython returns cpython-38-x86_64-linux-gnu but PyPy returns pypy36-pp73 where the correct value is pypy36-pp73-x86_64-linux-gnu.

I want to fix this on PyPy for our upcoming release, but then get_abi_tag will break. It correctly trims the platform tag off the SOABI value on line 94. Eventually we should get to a situation where line 94 works for both PyPy and CPython, but there needs to be a transition period based on either direct value parsing or some kind of version check.

Any thoughts? PyPy users are pretty good about updating, I think within a year we could drop any temporary shims we put in to work around this issue, under the assumption that by then anyone building a PyPy wheel will have upgraded to the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants