Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax importlib-metadata version pinning #1955

Closed
aachkar-miovision opened this issue Sep 30, 2020 · 2 comments
Closed

Relax importlib-metadata version pinning #1955

aachkar-miovision opened this issue Sep 30, 2020 · 2 comments

Comments

@aachkar-miovision
Copy link

Is this pinning to <2 of importlib-metadata required? It is preventing installing that version into environments where for example I also have pre-commit, which depends on virtualenv.

importlib-metadata>=0.12,<2;python_version<"3.8"

pre-commit 2.7.1 A framework for managing and maintaining multi-language pre-commit hooks.
├── cfgv >=2.0.0
├── identify >=1.0.0
├── importlib-metadata *
│   └── zipp >=0.5
├── nodeenv >=0.11.1
├── pyyaml >=5.1
├── toml *
└── virtualenv >=20.0.8
    ├── appdirs >=1.4.3,<2
    ├── distlib >=0.3.1,<1
    ├── filelock >=3.0.0,<4
    ├── importlib-metadata >=0.12,<2
    │   └── zipp >=0.5
    └── six >=1.9.0,<2
@gaborbernat
Copy link
Contributor

It's not required but we need a patch that removes it and makes the ci pass to validate it's not breaking things. Prs welcome.

@gaborbernat
Copy link
Contributor

Fixed via #1953

@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants