Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check pip config if such command is not available #1303

Conversation

daa
Copy link

@daa daa commented Jan 30, 2019

When virtualenv installs pip < 10 its config command is not available but this functionality is not critical for virtualenv creation so this pull request allows such behaviour.

Closes #1301

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder

@@ -0,0 +1 @@
Allow virtualenv creation with older pip not having ``config`` command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you here note that in this case configuration related features (such as pip cert setting) will not work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changelog entry but if you have better formulation I'll gladly use it.

@gaborbernat gaborbernat merged commit 23e7f7a into pypa:master Jan 30, 2019
@daa daa deleted the do-not-check-pip-config-if-such-command-is-not-available branch January 30, 2019 18:45
clrpackages referenced this pull request in clearlinux-pkgs/virtualenv Feb 15, 2019
…on 16.4.0

Anthony Sottile (2):
      Use importlib in python3 (#1293)
      virtualenv does not *always* have a runtime dependency on setuptools (#1300)

Bernat Gabor (2):
      release 16.4.0
      release 16.4.0

Bernát Gábor (2):
      Update virtualenv.py
      upgrade setuptools and pip (#1312)

daa (2):
      Do not check pip config if such command is not available (#1303)
      Link or copy PyPy headers instead of include directory as a whole (#1302)

rofl0r (1):
      fix handling of relative symlinks (#1309)

v16.4.0 (2019-02-09)
--------------------

Bugfixes
^^^^^^^^

- fixes the scenario where the python base install is symlinked with relative symlinks (`#490 <https://github.com/pypa/virtualenv/issues/490>`_)
- Use ``importlib`` over ``imp`` in ``virtualenv.py`` for ``python >= 3.4`` - by Anthony Sottile (`#1293 <https://github.com/pypa/virtualenv/issues/1293>`_)
- Copy or link PyPy header files instead of include directory itself (`#1302 <https://github.com/pypa/virtualenv/issues/1302>`_)
- Allow virtualenv creation with older pip not having ``config`` command
  correspondingly disabling configuration related features (such as pip cert
  setting) in this case. (`#1303 <https://github.com/pypa/virtualenv/issues/1303>`_)

Features

(NEWS truncated at 15 lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants