From 1de7c30f288502caf6f8b91ef9ae1feba697c5e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bern=C3=A1t=20G=C3=A1bor?= <bgabor8@bloomberg.net>
Date: Tue, 17 Mar 2020 16:52:11 +0000
Subject: [PATCH] add zip importer test (#1727)

Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
---
 docs/changelog/1715.bugfix.rst                |  2 ++
 .../create/via_global_ref/_virtualenv.py      |  5 +++-
 tests/unit/create/test_creator.py             | 23 +++++++++++++++++++
 3 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 docs/changelog/1715.bugfix.rst

diff --git a/docs/changelog/1715.bugfix.rst b/docs/changelog/1715.bugfix.rst
new file mode 100644
index 000000000..91cf9b016
--- /dev/null
+++ b/docs/changelog/1715.bugfix.rst
@@ -0,0 +1,2 @@
+Do not fail if the distutils/setuptools patch happens on a C-extension loader (such as ``zipimporter`` on Python 3.7 or
+earlier) - by :user:`gaborbernat`.
diff --git a/src/virtualenv/create/via_global_ref/_virtualenv.py b/src/virtualenv/create/via_global_ref/_virtualenv.py
index 5a1f76a02..b399da4cc 100644
--- a/src/virtualenv/create/via_global_ref/_virtualenv.py
+++ b/src/virtualenv/create/via_global_ref/_virtualenv.py
@@ -61,7 +61,10 @@ def find_spec(self, fullname, path, target=None):
                             old = getattr(spec.loader, func_name)
                             func = self.exec_module if is_new_api else self.load_module
                             if old is not func:
-                                setattr(spec.loader, func_name, partial(func, old))
+                                try:
+                                    setattr(spec.loader, func_name, partial(func, old))
+                                except AttributeError:
+                                    pass  # C-Extension loaders are r/o such as zipimporter with <python 3.7
                             return spec
                     finally:
                         self.fullname = None
diff --git a/tests/unit/create/test_creator.py b/tests/unit/create/test_creator.py
index 4d86ffd95..21959becc 100644
--- a/tests/unit/create/test_creator.py
+++ b/tests/unit/create/test_creator.py
@@ -9,6 +9,7 @@
 import stat
 import subprocess
 import sys
+import zipfile
 from collections import OrderedDict
 from itertools import product
 from stat import S_IREAD, S_IRGRP, S_IROTH
@@ -486,3 +487,25 @@ def exists():
     assert not (result.creator.stdlib / "os.py").exists()
     assert (result.creator.stdlib / "os.pyc").exists()
     assert "os.pyc" in result.creator.debug["os"]
+
+
+def test_zip_importer_can_import_setuptools(tmp_path):
+    """We're patching the loaders so might fail on r/o loaders, such as zipimporter on CPython<3.8"""
+    result = cli_run([str(tmp_path / "venv"), "--activators", "", "--no-pip", "--no-wheel", "--copies"])
+    zip_path = tmp_path / "site-packages.zip"
+    with zipfile.ZipFile(str(zip_path), "w", zipfile.ZIP_DEFLATED) as zip_handler:
+        lib = str(result.creator.purelib)
+        for root, _, files in os.walk(lib):
+            base = root[len(lib) :].lstrip(os.pathsep)
+            for file in files:
+                if not file.startswith("_virtualenv"):
+                    zip_handler.write(filename=os.path.join(root, file), arcname=os.path.join(base, file))
+    for folder in result.creator.purelib.iterdir():
+        if not folder.name.startswith("_virtualenv"):
+            if folder.is_dir():
+                shutil.rmtree(str(folder), ignore_errors=True)
+            else:
+                folder.unlink()
+    env = os.environ.copy()
+    env[str("PYTHONPATH")] = str(zip_path)
+    subprocess.check_call([str(result.creator.exe), "-c", "from setuptools.dist import Distribution"], env=env)