Fix twine( check) with the newly released pkginfo 1.9.

[Julian]

twine check (and transitively gh-action-pypi-publish) look like they were relying on a function in pkginfo which has just been removed.

It (the pkginfo release) removes distribution.must_decode, though that function was questionably public as it was an "exposed" compatibility function (removed as part of pkginfo dropping 2.7 support).

See https://bazaar.launchpad.net/~tseaver/pkginfo/trunk/revision/205

To reproduce the issue being fixed, run:

python3.11 -m venv venv && venv/bin/python -m pip install build -e . && venv/bin/pyproject-build . && venv/bin/twine check dist/*.whl

Which before this PR (and when 1.9.0 is pulled in from pkginfo) yields:

Checking dist/twine-4.0.2.dev1+gbb51e46-py3-none-any.whl: Traceback (most recent call last):
  File "/Users/julian/Development/twine/venv/bin/twine", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/julian/Development/twine/twine/__main__.py", line 33, in main
    error = cli.dispatch(sys.argv[1:])
            ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/julian/Development/twine/twine/cli.py", line 123, in dispatch
    return main(args.args)
           ^^^^^^^^^^^^^^^
  File "/Users/julian/Development/twine/twine/commands/check.py", line 183, in main
    return check(parsed_args.dists, strict=parsed_args.strict)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/julian/Development/twine/twine/commands/check.py", line 129, in check
    warnings, is_ok = _check_file(filename, render_warning_stream)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/julian/Development/twine/twine/commands/check.py", line 73, in _check_file
    package = package_file.PackageFile.from_filename(filename, comment=None)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/julian/Development/twine/twine/package.py", line 96, in from_filename
    meta = DIST_TYPES[dtype](filename)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/julian/Development/twine/twine/wheel.py", line 42, in __init__
    self.extractMetadata()
  File "/Users/julian/Development/twine/venv/lib/python3.11/site-packages/pkginfo/distribution.py", line 121, in extractMetadata
    self.parse(data)
  File "/Users/julian/Development/twine/twine/wheel.py", line 89, in parse
    fp = io.StringIO(distribution.must_decode(data))
                     ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pkginfo.distribution' has no attribute 'must_decode'. Did you mean: '_must_decode'?

Fixes #940.

[Julian]

Given the original function here seems to have been used mostly for 2.X sake, I went with just calling decode, and since the original function fell back to latin-1, I went with errors=replace. But I'm not sure the latter case can actually happen in real life (i.e. whether it'd be against the wheel spec anyhow)?

[Julian]

(Rebasing off of #942 to hopefully get CI passing).

[sigmavirus24]

Please rebase on main

[Julian]

Done.

[webknjaz]

and transitively gh-action-pypi-publish

FYI I've improved the stability of pypi-publish with pypa/gh-action-pypi-publish#108.

[jbylund]

Is there going to be a new release for this one? I know it's impacting some ci pipelines.

[bhrutledge]

I can do a release this evening. Thanks to everyone who's moving this along; I know I've been absent lately.

[bhrutledge]

Released: https://pypi.org/project/twine/4.0.2/