Fix client cert password bug #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@future-cyborg Sorry for the delay on this. I've asked @jaraco for a review, since he seems to have more context, but if he's not able to get to it soon, I'll take a closer look. |
jaraco
requested changes
Aug 10, 2020
jaraco
force-pushed
the
Fix-client_cert-password-bug
branch
from
e7ff37d
to
e15122e
Compare
|
The errors from Windows appears to be spurious failures. |
jaraco
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does change what flags would be required for a specific use-case, but there is better use-case coverage with this change.
twine --client-certwith no password will now prompt unless--non-interactiveis setFixes #579