Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern Python syntax features #436

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Use modern Python syntax features #436

merged 1 commit into from
Jan 8, 2019

Conversation

jdufresne
Copy link
Contributor

  • Can omit ordered .format() placeholder numbers
  • Use set literals
  • Use dict comprehension

Changes automated with the pyupgrade tool:

https://github.com/asottile/pyupgrade

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is 70%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files          14       14           
  Lines         751      751           
  Branches      108      108           
=======================================
  Hits          588      588           
  Misses        130      130           
  Partials       33       33
Impacted Files Coverage Δ
twine/commands/register.py 0% <0%> (ø) ⬆️
twine/cli.py 100% <100%> (ø) ⬆️
twine/commands/upload.py 75% <100%> (ø) ⬆️
twine/exceptions.py 100% <100%> (ø) ⬆️
twine/package.py 86.72% <100%> (ø) ⬆️
twine/utils.py 83.68% <100%> (ø) ⬆️
twine/repository.py 60.57% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f986cb...a7a8e0c. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is 70%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files          14       14           
  Lines         751      751           
  Branches      108      108           
=======================================
  Hits          588      588           
- Misses        129      130    +1     
+ Partials       34       33    -1
Impacted Files Coverage Δ
twine/commands/register.py 0% <0%> (ø) ⬆️
twine/cli.py 100% <100%> (ø) ⬆️
twine/commands/upload.py 75% <100%> (ø) ⬆️
twine/exceptions.py 100% <100%> (ø) ⬆️
twine/package.py 86.72% <100%> (ø) ⬆️
twine/utils.py 83.68% <100%> (ø) ⬆️
twine/repository.py 60.57% <33.33%> (ø) ⬆️
twine/wininst.py 31.57% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4d5ec...869392b. Read the comment docs.

- Can omit ordered .format() placeholder numbers
- Use set literals
- Use dict comprehension

Changes automated with the pyupgrade tool:

https://github.com/asottile/pyupgrade
@jaraco jaraco mentioned this pull request Jan 8, 2019
@jaraco jaraco merged commit 5a72af1 into pypa:master Jan 8, 2019
@jdufresne jdufresne deleted the pyup branch January 8, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants