Raise exception if attempting upload to deprecated legacy PyPI URLs #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 68.51% 69.53% +1.02%
==========================================
Files 12 12
Lines 578 581 +3
Branches 91 91
==========================================
+ Hits 396 404 +8
+ Misses 156 149 -7
- Partials 26 28 +2
Continue to review full report at Codecov.
|
theacodes
approved these changes
Mar 18, 2018
brainwane
force-pushed
the
deprecated-URL-exception
branch
2 times, most recently
from
cf16b33
to
5c864af
Compare
Now that legacy (deprecated) URLs give a 410 Gone, Twine should just watch for those URLs and give an actionable error rather than transmit the upload request. Fixes #307.
brainwane
force-pushed
the
deprecated-URL-exception
branch
from
5c864af
to
ecff890
Compare
|
@jonparrott I've revised the exception handling; take another look? |
dstufft
approved these changes
Mar 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that legacy (deprecated) URLs give a
410 Gone, Twine should just watch for those URLs and give an actionable error rather than transmit the upload request.Fixes #307.