Add 409 status code support to --skip-existing #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twine only supported the 400 status code when deciding to skip an upload. However, alternative implementations of pypi, for example [pypiserver](http://github.com/pypiserver/pypiserver), use a 409 status code.
andrewwatts
changed the title
|
Closing/re-opening to trigger a new merged build on Travis. |
|
"alternative implementations of PyPI" should be API compatible. That said, I don't think PyPI returns a 409 for anything (that could cause a problem here). This should also allow @dstufft to have warehouse return 409 if he agrees that's a the better status code (I agree that it's the correct one). |
sigmavirus24
added a commit
that referenced
this pull request
Jan 28, 2016
Add 409 status code support to --skip-existing
|
Maybe for status code 409 it should stop inspecting the status message? |
|
Good point @dstufft. |
sigmavirus24
added a commit
to sigmavirus24/twine
that referenced
this pull request
Jan 28, 2016
Alternative package servers may return a 409 without the same message stored in the reason attribute that PyPI does. In that case, skip inspecting the reason message otherwise we will fail to skip that upload when the user specified --skip-existing. Ref: pypagh-162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twine only supported the 400 status code when deciding to skip an upload. However, alternative implementations of pypi, for example pypiserver, use a 409 status code.