Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression: Vendored jaraco.text cannot be loaded when using Bazel #4605

Closed
janhicken opened this issue Aug 27, 2024 · 2 comments
Closed
Labels
bug Needs Triage Issues that need to be evaluated for severity and status.

Comments

@janhicken
Copy link

setuptools version

setuptools>=71.0.0

Python version

Python 3.10

OS

Arch Linux

Additional environment information

No response

Description

After setuptools' dependencies have been re-vendored, the issue #3072 surfaced again.

The file Lorem ipsum.txt from jaraco.text is loaded again here, which used to be removed in this fix.

This is a problem when using setuptools with Bazel, because it does not support paths with spaces.

Expected behavior

See #3072.

How to Reproduce

See #3072.

Output

See #3072.

@janhicken janhicken added bug Needs Triage Issues that need to be evaluated for severity and status. labels Aug 27, 2024
@abravalheri
Copy link
Contributor

abravalheri commented Aug 27, 2024

Hi @janhicken have you tried to discuss this problem with the bazel maintainers? As noted in #3072 this is not really a bug in the setuptools code base but rather in bazel and/or rules Python.

I did open an issue a while ago in rules_python giving a heads up that the patch introduced in #3077 was not bullet proof and that the problem could re-surface. The issue was closed in favour bazelbuild/bazel#4327.

I do believe that the best place to solve this problem is in bazel, and it is not really a bug in the setuptools implementation.

/cc @jaraco

@janhicken
Copy link
Author

I agree with you, maybe #3077 should not have been implemented in the first place, because upgrading to setuptools>=71.0.0 now feels like a regression.

Also, my issue is probably a duplicate of #4487 where this was already discussed in more detail. @jaraco already mentioned is intention to not fix the issue here.

As Bazel 7.0 introduced experimental support for dealing with spaces in paths (--experimental_inprocess_symlink_creation), this missing piece seems to be https://github.com/bazelbuild/rules_python not supporting that.

I'm going to open an issue there and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Development

No branches or pull requests

2 participants