Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release blocked by non-published test dependency pytest-virtualenv #2881

Closed
jaraco opened this issue Nov 14, 2021 · 4 comments · Fixed by #2882
Closed

Release blocked by non-published test dependency pytest-virtualenv #2881

jaraco opened this issue Nov 14, 2021 · 4 comments · Fixed by #2882

Comments

@jaraco
Copy link
Member

jaraco commented Nov 14, 2021

I think there might be a problem with using:

[options.extras_require]
testing =
        ...
-	pytest-virtualenv>=1.2.7
+	pytest-virtualenv @ git+https://github.com/jaraco/pytest-plugins@distutils-deprecated#subdirectory=pytest-virtualenv

in setup.cfg.

I am almost sure PyPI forbid uploading packages with dependencies outside of PyPI.
pypa/build may also have problems when parsing the dependencies for PEP517 style builds...

Originally posted by @abravalheri in #2865 (comment)

@jaraco
Copy link
Member Author

jaraco commented Nov 14, 2021

Confirmed. Good catch. I can see in https://github.com/pypa/setuptools/runs/4196605393?check_suite_focus=true this output:

Error during upload. Retry with the --verbose option for more details.
HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: "pytest-virtualenv @ git+https://github.com/jaraco/pytest-plugins@distutils-deprecated#subdirectory=pytest-virtualenv ; extra == 'testing'"

So the v59 release was rejected.

Pytest-virtualenv (and the other plugins in man-group/pytest-plugins) are poorly-maintained, so I'm not hopeful my pull request will be reviewed, accepted, released anytime soon.

I'm not sure what to do with this other than to fork the project or port its functionality to another project.

I've noticed that this project (Setuptools) already is using jaraco.envs for some of the tests requiring isolated environments for testing. Perhaps the best thing would be to migrate the tests to jaraco.envs.

@abravalheri
Copy link
Contributor

abravalheri commented Nov 14, 2021

Hi @jaraco, I think a temporary solution is to overwrite the test dependency via tox.ini. I am working in a PR that does that, right now.

Hopefully it will work

@jaraco
Copy link
Member Author

jaraco commented Nov 14, 2021

Aha. I see this is now a dupe of #2880.

@abravalheri
Copy link
Contributor

I've noticed that this project (Setuptools) already is using jaraco.envs for some of the tests requiring isolated environments for testing. Perhaps the best thing would be to migrate the tests to jaraco.envs.

I think that would be a positive change. I usually avoid pytest-virtualenv because it is not straight forward to use sometimes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants